Use safer SQL query to guarantee column order#4459
Merged
jixuan1989 merged 1 commit intoapache:masterfrom Nov 24, 2021
shunfan-shao:switch-to-safer-sql-query
Merged
Use safer SQL query to guarantee column order#4459jixuan1989 merged 1 commit intoapache:masterfrom shunfan-shao:switch-to-safer-sql-query
jixuan1989 merged 1 commit intoapache:masterfrom
shunfan-shao:switch-to-safer-sql-query
Conversation
jixuan1989
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test
testSelectColumnStatementWithTimeFilterfails under NonDex tool which detects flakiness of usage with non-deterministic data structures. The failure behavior is defined by incorrect ordering of column data.Reproduce
To reproduce:
mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl zeppelin-interpreter -Dtest=org.apache.zeppelin.iotdb.IoTDBInterpreterTest#testSelectColumnStatementWithTimeFilter -DnondexRuns=10Issue
I suspect the cause comes from the query, whereas
*makes the result order inconsistent.This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR